Test rust 4 by 2bndy5 · Pull Request #56 · cpp-linter/test-cpp-linter-action

2bndy5 · 2026-06-21T21:42:31Z

Now with PR review suggestions unified (from both tools) and thread comments that boast available auto-fixes.

and try cpp-linter-action v3.0-rc0 branch

github-actions · 2026-06-21T21:47:45Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v17.0.6) reports: 2 file(s) not formatted

src/demo.cpp (11 lines)
src/demo.hpp (25 lines)

clang-tidy (v17.0.1) reports: 8 concern(s)

src/demo.cpp

src/demo.cpp:2:1: warning: [misc-include-cleaner]
⚡ auto-fix available

included header demo.hpp is not used directly
```
    2 | #include "demo.hpp"
      | ^~~~~~~~~~~~~~~~~~~
    3 | #include <stdio.h>
```
src/demo.cpp

src/demo.cpp:3:10: warning: [modernize-deprecated-headers]
⚡ auto-fix available

inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
```
    3 | #include <stdio.h>
      |          ^~~~~~~~~
      |          <cstdio>
```
src/demo.cpp

src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]
⚡ auto-fix available

use a trailing return type for this function
```
    8 | int main(){
      | ~~~ ^     
      | auto       -> int
```
src/demo.cpp

src/demo.cpp:10:13: warning: [readability-braces-around-statements]
⚡ auto-fix available

statement should be inside braces
```
   10 |     for (;;) break;
      |             ^      
      |              {
```
src/demo.cpp

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions
```
   13 |     printf("Hello world!\n");
      |     ^
```

src/demo.hpp

src/demo.hpp:6:11: warning: [cppcoreguidelines-use-default-member-init]
⚡ auto-fix available

use default member initializer for 'useless'

    6 |     char* useless;
      |           ^      
      |                  {"\0"}
    7 |     int numb;
    8 |     Dummy() :numb(0), useless("\0"){}
      |                       ~~~~~~~~~~~~~

src/demo.hpp

src/demo.hpp:7:9: warning: [cppcoreguidelines-use-default-member-init]
⚡ auto-fix available

use default member initializer for 'numb'

    7 |     int numb;
      |         ^   
      |             {0}
    8 |     Dummy() :numb(0), useless("\0"){}
      |              ~~~~~~~

src/demo.hpp

src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]
⚡ auto-fix available

use a trailing return type for this function

   11 |     void *not_useful(char *str){useless = str;}
      |     ~~~~~~^                    
      |     auto                        -> void *

Have any feedback or feature suggestions? Share it here.

keeps build artifacts in the build/ folder

github-actions

Cpp-linter Review

Used clang-format v17.0.6

Used clang-tidy v17.0.1

Only 8 out of 10 concerns fit within this pull request's diff.

Click here for a patch of fixes outside the diff

--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +3,0 @@
-
-
@@ -14,19 +12,1 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-06-23T10:51:30Z

 /** This is a very ugly test code (doomed to fail linting) */
 #include "demo.hpp"


clang-tidy diagnostic(s)

included header demo.hpp is not used directly [misc-include-cleaner]

Suggested change

/** This is a very ugly test code (doomed to fail linting) */

#include "demo.hpp"

#include <cstdio>

github-actions · 2026-06-23T10:51:30Z

 #include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
+#include <stdio.h>


clang-tidy diagnostic(s)

inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]

Suggested change

#include <stdio.h>

auto main() -> int

{

github-actions · 2026-06-23T10:51:30Z


-int main()
-{
-    for (;;)
-        break;
+
+
+int main(){
+
+    for (;;) break;


clang-tidy diagnostic(s)

use a trailing return type for this function [modernize-use-trailing-return-type]

statement should be inside braces [readability-braces-around-statements]

Suggested change

int main()

{

for (;;)

break;

int main(){

for (;;) break;

for (;;) {

break;

}

github-actions · 2026-06-23T10:51:30Z


-    return 0;
-}
+
+
+


clang-tidy suggestion

Suggested change

return 0;

}

return 0;

}

github-actions · 2026-06-23T10:51:30Z

+    for (;;) break;
+

    printf("Hello world!\n");


clang-tidy diagnostic

src/demo.cpp:13:5 warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf("Hello world!\n"); | ^

github-actions · 2026-06-23T10:51:30Z

 class Dummy {
    char* useless;
    int numb;


clang-tidy diagnostic(s)

use default member initializer for 'useless' [cppcoreguidelines-use-default-member-init]

use default member initializer for 'numb' [cppcoreguidelines-use-default-member-init]

Suggested change

class Dummy {

char* useless;

int numb;

char* useless { "\0" };

int numb { 0 };

Dummy() { }

github-actions · 2026-06-23T10:51:30Z


    public:


clang-tidy suggestion

Suggested change

public:

public:

auto not_useful(char* str) -> void* { useless = str; }

github-actions · 2026-06-23T10:51:30Z

 struct LongDiff
 {
+
    long diff;


clang-tidy suggestion

Please remove the line(s)

34

I think it is supposed to say line 33 not 34 here. I need to investigate. For some reason, this logic is not covered in the tests.

outdated review

github-actions

Cpp-linter Review

Used clang-format v17.0.6

Used clang-tidy v17.0.1

Only 8 out of 10 concerns fit within this pull request's diff.

8 suggestions were duplicates of previous reviews.

Click here for a patch of fixes outside the diff

--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +3,0 @@
-
-
@@ -14,19 +12,1 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {

Have any feedback or feature suggestions? Share it here.

2bndy5 · 2026-06-24T10:06:43Z

@shenxianpeng check out the new thread comment format. The clang-format list of files now shows the number of lines that need formatting (per file). And the clang-tidy notes now show if there is an auto-fix available (" ⚡ auto-fix available").

Also, the PR reviews are being reused in this test. So, the PR review summary only shows a patch of changes that does not fit in the diff (because lines-changed-only is off right now).

I'm open to feedback about the new comments. Personally I think the clang versions used might look better in a MD table:

Used clang-format v17.0.6

Used clang-tidy v17.0.1

tool	version
clang-format	v17.0.6
clang-tidy	v17.0.1

2bndy5 · 2026-06-24T10:18:29Z

This is not supposed to happen if there were reused review suggestions.

2bndy5 added 9 commits June 5, 2026 13:31

prepare for rust pkg tests

f46a6f2

enable PR reviews

98cb22d

switch to main branch

8fd5a8f

enable color logs

356d61a

update src/demo.* and clang configs

6609051

turn off line filter

8e685fa

install software-properties-common in linux container too

93ef4e0

bump to v2.0.0rc18

0fa4be8

and try cpp-linter-action v3.0-rc0 branch

bump to cppv2.0.0-rc19

2f7cee7

2bndy5 added 2 commits June 23, 2026 03:35

fix CMake cmd

1a40e9c

keeps build artifacts in the build/ folder

switch to pkg CI

d380674

github-actions Bot requested changes Jun 23, 2026

View reviewed changes

enable step summary

648dcaa

This comment was marked as outdated.

Sign in to view

bump to cpp-linter v2.0.0-rc20

31dff3c

github-actions Bot requested changes Jun 24, 2026

View reviewed changes

		/** This is a very ugly test code (doomed to fail linting) */
		#include "demo.hpp"

	/** This is a very ugly test code (doomed to fail linting) */
	#include "demo.hpp"
	#include <cstdio>

-    public:
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Conversation

2bndy5 commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.6

Used clang-tidy v17.0.1

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy suggestion

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy suggestion

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy suggestion

Uh oh!

2bndy5 Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.6

Used clang-tidy v17.0.1

Uh oh!

2bndy5 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Used clang-format v17.0.6

Used clang-tidy v17.0.1

Uh oh!

2bndy5 commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Jun 21, 2026 •

edited

Loading

2bndy5 Jun 24, 2026 •

edited

Loading

2bndy5 commented Jun 24, 2026 •

edited

Loading